Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to render type handling #529

Merged
merged 7 commits into from
Jan 13, 2024

Conversation

embeddedt
Copy link

@embeddedt embeddedt commented Jan 4, 2024

This should prevent issues if mods use Forge's registry replacement to register their own versions of blocks.

It also fixes the cause of #486 not being fixed with mods installed: BakedModel#getRenderTypes does not always use the central registry that Iris' mixins redirect, as Forge models are allowed to specify their own render types. We need to redirect the calls to this method from the chunk meshers.

@embeddedt embeddedt changed the title Use Forge delegates as map keys instead of blocks themselves Improvements to render type handling Jan 4, 2024
Fixes glass not being translucent with mods like XyCraft, as they
override these methods
@dima-dencep dima-dencep merged commit b613f2e into Asek3:1.20 Jan 13, 2024
1 check passed
Asek3 added a commit that referenced this pull request Jan 26, 2024
[1.16] Port #529 and clean up build system
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants